fix: enable checking doc attributes on entrypoint function to fix #14491 #14505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
☔ The latest upstream changes (possibly d28d234) made this pull request unmergeable. Please resolve the merge conflicts. |
rustbot
added
S-waiting-on-author
dswij
reviewed
Apr 28, 2025
| @@ -0,0 +1,29 @@ | |||
| //@aux-build:macro_rules.rs | |||
There was a problem hiding this comment.
We'd prefer to have this test together in tests/ui/missing_panics_doc.rs.
| if !(is_entrypoint_fn(cx, item.owner_id.to_def_id()) | ||
| || item.span.in_external_macro(cx.tcx.sess.source_map())) | ||
| { | ||
| if !(item.span.in_external_macro(cx.tcx.sess.source_map())) { |
There was a problem hiding this comment.
seems the extra parentheses () is unnecessary here.
Suggested change
| if !(item.span.in_external_macro(cx.tcx.sess.source_map())) { | |
| if !item.span.in_external_macro(cx.tcx.sess.source_map()) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14491
I'm not so sure about the expected behaviour here, I presume that one should document panics and errors on
main?So I remove the
is_entrypoint_fnhere.changelog: [
missing_panics_doc&missing_panics_doc]: enable checking doc attributes on entrypoint function